NAS-135917 / 26.04 / SPDK backend for NVMe-oF #16562
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmeagherix
changed the title
bmeagherix
force-pushed
the
NAS-135917
branch
3 times, most recently
from
5b0ee9d to
008511a
Compare
bmeagherix
force-pushed
the
NAS-135917
branch
3 times, most recently
from
d29699e to
74337d2
Compare
bmeagherix
force-pushed
the
NAS-135917
branch
2 times, most recently
from
d2afe48 to
bc32349
Compare
bmeagherix
force-pushed
the
NAS-135917
branch
2 times, most recently
from
6507884 to
a7dbb72
Compare
bmeagherix
force-pushed
the
NAS-135917
branch
2 times, most recently
from
13b5239 to
9c2692c
Compare
bmeagherix
force-pushed
the
NAS-135917
branch
from
4123aae to
834a925
Compare
bmeagherix
changed the title
First fixed up path_to_recordsize, and then disabled it because found that linux client could not properly handle what SPDK was reporting.
Some adjustment was required wrt referrals as SPDK is more generous in this respect.
bmeagherix
force-pushed
the
NAS-135917
branch
from
60dfee1 to
3bf5060
Compare
yocalebo
requested changes
Oct 17, 2025
yocalebo
reviewed
Oct 17, 2025
yocalebo
approved these changes
Oct 17, 2025
|
JIRA ticket https://ixsystems.atlassian.net/browse/NAS-135917 is targeted to the following versions which have not received their corresponding PRs: 26.04 |
|
This PR has been merged and conversations have been locked. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add middleware plumbing for SPDK NVMe-oF backend.
Depending on the
kernelsetting innvmet.global.configthe configuration will either be applied to the kernel NVMe-oF target, or to a SPDK based target. This PR adds support for the latter.Overview
If the kernel implementation is not selected, then a user-space daemon is launched. The
ix-nvmfservice is a thin wrapper around the/opt/spdk/usr/bin/nvmf_tgtexecutable that calls into middleware to perform some necessary setup/teardown. Before the executable is launched, some DPDK setup is performed, and after it has been launched the configuration is "applied" to it.A python library is delivered as part of SPDK, and is called directly from middleware to configure the daemon. So, it will "create" ports, subsystems, namespaces, bdevs, etc within the daemon.
Tests
Existing NVMe-oF tests are now called both for kernel and for SPDK implementations, using parametrized fixtures. Some minor test fixup was required, most especially because SPDK is more "generous" in referral creation.
Missing
The following items have not been addressed in this PR:
vfio-pciinstead (i.e. dedicated NICs).Following PR review/address review/PR approve did another CI run here. Passes all NVMe-oF tests.